Fixed bug of scheduler generated events overlapping with scheduled events#120
Merged
trappaly merged 1 commit intodevelopmentfrom May 11, 2025
Merged
Conversation
trappaly
reviewed
May 11, 2025
| const dayEnd = userPreferences.endTime; | ||
| const futureEvents = events | ||
| const minutesToDayEnd = dayEnd - currentMinutes; | ||
| const dayEndDate = new Date(time.getTime() + minutesToDayEnd * 60000); |
Collaborator
There was a problem hiding this comment.
Fixed ending times for events
trappaly
reviewed
May 11, 2025
| if (futureEvents.length > 0) { | ||
| return ( | ||
| UserPreferenceUtils.dateToMinuteNumber(futureEvents[0].start_time) - | ||
| currentMinutes |
Collaborator
There was a problem hiding this comment.
Changed future events to future events on this day
trappaly
reviewed
May 11, 2025
Collaborator
trappaly
left a comment
trappaly
left a comment
There was a problem hiding this comment.
Fixed the bug of changing the minutes to next event in the scheduling algorithm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed minutesToNextEvent function which was non-functional. The bug led to all generated events having the same length. Now it aligns with the actual amount of minutes the user has available, so there isn't overlap.
Relevant information could be found on Trello: https://trello.com/c/H1a54YOH/200-debug-events-generated-are-not-across-all-free-time-block-sometimes-overlap-pre-existing-events